incubator/dirl
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Remove server-architecture specifics from serve() and add them to main()

Browse source 
To make the code a bit more flexible, let's get rid of the forking-code
in serve() and do it in main(). This way, we are more liberal in the
future to possibly handle it in a different way.
This commit is contained in:
Laslo Hunhold 2018-02-05 17:15:29 +01:00
parent e35d3e1287
commit f6f98c9e64
1 changed files with 54 additions and 58 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

112
main.c
View file

@ -24,68 +24,41 @@
static char *udsname; static char *udsname;
static void static void
serve(int insock) serve(int infd, struct sockaddr_storage *in_sa)
{ {
struct request r; struct request r;
struct sockaddr_storage in_sa;
pid_t p;
socklen_t in_sa_len;
time_t t; time_t t;
enum status status; enum status status;
int infd;
char inaddr[INET6_ADDRSTRLEN /* > INET_ADDRSTRLEN */]; char inaddr[INET6_ADDRSTRLEN /* > INET_ADDRSTRLEN */];
char tstmp[25]; char tstmp[25];
while (1) { /* set connection timeout */
/* accept incoming connections */ if (sock_set_timeout(infd, 30)) {
in_sa_len = sizeof(in_sa); goto cleanup;
if ((infd = accept(insock, (struct sockaddr *)&in_sa,
&in_sa_len)) < 0) {
warn("accept:");
continue;
}
/* fork and handle */
switch ((p = fork())) {
case -1:
warn("fork:");
break;
case 0:
close(insock);
/* set connection timeout */
if (sock_set_timeout(infd, 30)) {
goto cleanup;
}
/* handle request */
if (!(status = http_get_request(infd, &r))) {
status = http_send_response(infd, &r);
}
/* write output to log */
t = time(NULL);
if (!strftime(tstmp, sizeof(tstmp), "%Y-%m-%dT%H:%M:%S",
gmtime(&t))) {
warn("strftime: Exceeded buffer capacity");
goto cleanup;
}
if (sock_get_inaddr_str(&in_sa, inaddr, LEN(inaddr))) {
goto cleanup;
}
printf("%s\t%s\t%d\t%s\t%s\n", tstmp, inaddr, status,
r.field[REQ_HOST], r.target);
cleanup:
/* clean up and finish */
shutdown(infd, SHUT_RD);
shutdown(infd, SHUT_WR);
close(infd);
exit(0);
default:
/* close the connection in the parent */
close(infd);
}
} }
/* handle request */
if (!(status = http_get_request(infd, &r))) {
status = http_send_response(infd, &r);
}
/* write output to log */
t = time(NULL);
if (!strftime(tstmp, sizeof(tstmp), "%Y-%m-%dT%H:%M:%S",
gmtime(&t))) {
warn("strftime: Exceeded buffer capacity");
goto cleanup;
}
if (sock_get_inaddr_str(in_sa, inaddr, LEN(inaddr))) {
goto cleanup;
}
printf("%s\t%s\t%d\t%s\t%s\n", tstmp, inaddr, status,
r.field[REQ_HOST], r.target);
cleanup:
/* clean up and finish */
shutdown(infd, SHUT_RD);
shutdown(infd, SHUT_WR);
close(infd);
} }
static void static void
@ -128,11 +101,13 @@ usage(void)
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
struct passwd *pwd = NULL;
struct group *grp = NULL; struct group *grp = NULL;
struct passwd *pwd = NULL;
struct rlimit rlim; struct rlimit rlim;
pid_t cpid, wpid; struct sockaddr_storage in_sa;
int i, insock, status = 0; pid_t cpid, wpid, spid;
socklen_t in_sa_len;
int i, insock, status = 0, infd;
ARGBEGIN { ARGBEGIN {
case 'd': case 'd':
@ -251,7 +226,28 @@ main(int argc, char *argv[])
die("Won't run as root group", argv0); die("Won't run as root group", argv0);
} }
serve(insock); /* accept incoming connections */
while (1) {
in_sa_len = sizeof(in_sa);
if ((infd = accept(insock, (struct sockaddr *)&in_sa,
&in_sa_len)) < 0) {
warn("accept:");
continue;
}
/* fork and handle */
switch ((spid = fork())) {
case -1:
warn("fork:");
continue;
case 0:
serve(infd, &in_sa);
break;
default:
/* close the connection in the parent */
close(infd);
}
}
exit(0); exit(0);
default: default:
while ((wpid = wait(&status)) > 0) while ((wpid = wait(&status)) > 0)