suckless-quark/resp.h

/* See LICENSE file for copyright and license details. */
#ifndef RESP_H
#define RESP_H

#include <sys/stat.h>
#include <sys/types.h>

#include "http.h"

enum status resp_dir(int, const char *, const struct request *);
enum status resp_file(int, const char *, const struct request *,
                      const struct stat *, const char *, size_t, size_t);

#endif /* RESP_H */
Refactor the single source file into multiple modules And many other things, too many to list here. For example, it now properly logs uds instead of erroring out. Separating concerns in many places definitely improves the readability. 2018-02-04 20:27:33 +00:00			`/* See LICENSE file for copyright and license details. */`
			`#ifndef RESP_H`
			`#define RESP_H`

			`#include <sys/stat.h>`
			`#include <sys/types.h>`

			`#include "http.h"`

Ensure const-correctness where possible and refactor parse_range() I know that the effect of 'const' on compiler optimizations is smaller than many believe, but it provides a good insight to the caller which parameters are not modified and simplifies parallelization, in case that is desired at a later point. Throughout processing, the big structs mostly remained unmodified, with the exception of parse_range(), which added a null-byte in the "Range"- header to simplify its parsing. This commit refactors parse_range() such that it won't modify this string anymore. Additionally, the parser was made even stricter: Usually, strtoll() (which is wrapped by strtonum()) allows whitespace and plus and minus signs before the number, which is not part of the specification. The stricter parser also better differentiates now between invalid requests and range-lists. In that context, the switch in http_send_response() was replaced for better readability. Signed-off-by: Laslo Hunhold <dev@frign.de> 2020-08-05 16:28:21 +00:00			`enum status resp_dir(int, const char , const struct request );`
			`enum status resp_file(int, const char , const struct request ,`
Replace off_t with size_t While off_t might be better suited for file-offsets and -sizes, the IEEE Computer Society was unable to mandate limits (min, max) for it in the POSIX specification in the last 32 years. Because it's impossible to portably determine these numbers for signed integers, I decided to switch to size_t for the offsets to be able to pass proper values to strtonum(), because C99 is sane and has defined limits for size_t (i.e. SIZE_MIN and SIZE_MAX). On my system, long long and off_t have the same size, so it didn't trigger any bugs, but strtonum() could pass a bigger number to lower and upper than they can handle and make them overflow. The rationale for switching to size_t is actually given by the fact that functions like mmap() blur the border between memory and filesystem. Another point is that glibc has a horrible define _FILE_OFFSET_BITS you need to set to 64 to actually get decent values for off_t, which was a huge headache in sbase until we found that out. Signed-off-by: Laslo Hunhold <dev@frign.de> 2020-08-05 16:59:55 +00:00			`const struct stat , const char , size_t, size_t);`
Refactor the single source file into multiple modules And many other things, too many to list here. For example, it now properly logs uds instead of erroring out. Separating concerns in many places definitely improves the readability. 2018-02-04 20:27:33 +00:00
			`#endif /* RESP_H */`