playground/suckless-quark
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

byte-range: fix range check for upper limit

Browse source 
the range check was done after the check lower > upper
so if it meets these conditions: lower <= upper and
lower > st.st_size then lower could still be > upper.
This commit is contained in:
Hiltjo Posthuma 2017-07-04 18:18:24 +02:00 committed by Laslo Hunhold
parent a092d9aa4b
commit 9b8e2bdeb6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
quark.c
View file

@ -667,10 +667,10 @@ sendresponse(int fd, struct request *r)
} }
/* sanitize range */ /* sanitize range */
upper = MIN(st.st_size, upper);
if (lower < 0 || upper < 0 || lower > upper) { if (lower < 0 || upper < 0 || lower > upper) {
return sendstatus(fd, S_BAD_REQUEST); return sendstatus(fd, S_BAD_REQUEST);
} }
upper = MIN(st.st_size, upper);
} }
/* mime */ /* mime */