playground/suckless-quark
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed buffer overflow when p-res==targetlen in function getreqentry

Browse source
This commit is contained in:
Adria Garriga 2014-08-07 02:11:46 +02:00 committed by FRIGN
parent e9408312e1
commit abec80e6ce
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
quark.c
View file

@ -363,7 +363,7 @@ getreqentry(char *name, char *target, size_t targetlen, char *breakchars) {
for(p = res; *p && !strchr(breakchars, *p); ++p); for(p = res; *p && !strchr(breakchars, *p); ++p);
if(!*p) if(!*p)
return 1; return 1;
if((size_t)(p - res) > targetlen) if((size_t)(p - res) >= targetlen)
return 1; return 1;
memcpy(target, res, p - res); memcpy(target, res, p - res);
target[p - res] = 0; target[p - res] = 0;